qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [kvm-unit-tests PATCH v4 10/11] arm/arm64: gicv3: add an


From: Andrew Jones
Subject: Re: [Qemu-arm] [kvm-unit-tests PATCH v4 10/11] arm/arm64: gicv3: add an IPI test
Date: Wed, 9 Nov 2016 09:33:49 +0100
User-agent: Mutt/1.6.0.1 (2016-04-01)

Argh. I forgot to compile/test arm32/gicv3... Just did now and found
a copy+paste error.

On Tue, Nov 08, 2016 at 09:21:38PM +0100, Andrew Jones wrote:
[...]
> diff --git a/lib/arm/asm/arch_gicv3.h b/lib/arm/asm/arch_gicv3.h
> index 81a1e5f6c29c..cbcec024a2a6 100644
> --- a/lib/arm/asm/arch_gicv3.h
> +++ b/lib/arm/asm/arch_gicv3.h
> @@ -16,10 +16,28 @@
>  #define __stringify xstr
>  
>  #define __ACCESS_CP15(CRn, Op1, CRm, Op2)    p15, Op1, %0, CRn, CRm, Op2
> +#define __ACCESS_CP15_64(Op1, CRm)           p15, Op1, %Q0, %R0, CRm
>  
> +#define ICC_EOIR1                    __ACCESS_CP15(c12, 0, c12, 1)
> +#define ICC_IAR1                     __ACCESS_CP15(c12, 0, c12, 0)
> +#define ICC_SGI1R                    __ACCESS_CP15_64(0, c12)
>  #define ICC_PMR                              __ACCESS_CP15(c4, 0, c6, 0)
>  #define ICC_IGRPEN1                  __ACCESS_CP15(c12, 0, c12, 7)
>  
> +static inline void gicv3_write_eoir(u32 irq)
> +{
> +     asm volatile("mcr " __stringify(ICC_EOIR1) : : "r" (val));
                                              should be irq ^^
> +     isb();
> +}
> +
[...]

I've pushed an arm/gic-v5 branch[*] to github, and removed the broken
arm/gic-v4 branch.

[*] https://github.com/rhdrjones/kvm-unit-tests/commits/arm/gic-v5

drew



reply via email to

[Prev in Thread] Current Thread [Next in Thread]