qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support


From: Cédric Le Goater
Subject: Re: [Qemu-arm] [PATCH 3/4] hw/timer: Add Epson RX8900 RTC support
Date: Fri, 18 Nov 2016 09:52:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

>>> +/**
>>> + * Initialize the device
>>> + * @param i2c the i2c device instance
>>> + */
>>> +static int rx8900_init(I2CSlave *i2c)
>>> +{
>>> +    TRACE(*i2c, "Initialized");
>>> +
>>> +    return 0;
>>> +}
>>
>> you can remove this routine.
>>
> 
> I don't think I can, core.c:i2c_slave_qdev_init() calls it without a
> guard.

ah yes. So may be, we should add a test in i2c_slave_qdev_init() and
kill these :

        ds1338_init
        pxa2xx_i2c_slave_init
        aer915_init
        tosa_dac_init

it looks like a good cleanup. 

Thanks,

C.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]