Re: [Qemu-arm] [PATCH 2/4] qtest: Support named interrupts

[Paolo Bonzini]

On 22/11/2016 23:31, Alastair D'Silva wrote:
>>>> > > > +        if (irq == NULL) {
>>>> > > > +            qtest_send_prefix(chr);
>>>> > > > +            qtest_send(chr, "FAIL Unknown IRQ\n");
>>>> > > > +            return;
>>>> > > > +        }
>>>> > > > +
>>>> > > > +        qemu_set_irq(irq, level);
>> > 
>> > This seems wrong.  The IRQ should not be modifiable by the test.
>> > 
>> > Paolo
>> > 
> Thanks Paolo, could you please advise as to why that is?
> 
> The situation I am addressing is that I device under test that changes
> behaviour when a GPIO line is raised. Is there another way I should be
> raising that line from within qtest?

What causes the GPIO line to be raised in the normal emulated case?

Paolo