[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v5 3/7] qtest: Support setting named GPIOs
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v5 3/7] qtest: Support setting named GPIOs |
Date: |
Mon, 16 Jan 2017 15:00:21 +0000 |
On 5 January 2017 at 04:34, Alastair D'Silva <address@hidden> wrote:
> From: Alastair D'Silva <address@hidden>
>
> Some devices change their behaviour based on the state of their input GPIO
> lines.
>
> This patch allows testing of the variable behaviour by providing facilities
> for the test to set the state of these GPIO lines.
>
> Signed-off-by: Alastair D'Silva <address@hidden>
I still think this is wrong, I'm afraid. The GPIO line is
already connected to something else in the simulation,
and injecting a value that didn't come from whatever else
it's connected to is likely to confuse things.
Tests should work by programming the device that is connected
to the other end of this GPIO to make it raise the line.
thanks
-- PMM
- [Qemu-arm] [PATCH v5 0/7] Add support for the Epson RX8900 RTC to the aspeed board, Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 3/7] qtest: Support setting named GPIOs, Alastair D'Silva, 2017/01/04
- Re: [Qemu-arm] [PATCH v5 3/7] qtest: Support setting named GPIOs,
Peter Maydell <=
- [Qemu-arm] [PATCH v5 7/7] arm: Add an RX8900 RTC to the ASpeed board, Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 1/7] arm: Uniquely name imx25 I2C buses., Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 4/7] qtest: Fix whitespace, Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 6/7] tests: Test all implemented RX8900 functionality, Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 2/7] qtest: Support named interrupts, Alastair D'Silva, 2017/01/04
- [Qemu-arm] [PATCH v5 5/7] hw/timer: Add Epson RX8900 RTC support, Alastair D'Silva, 2017/01/04