[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v8 25/25] tcg: enable MTTCG by default for ARM on
From: |
Alex Bennée |
Subject: |
Re: [Qemu-arm] [PATCH v8 25/25] tcg: enable MTTCG by default for ARM on x86 hosts |
Date: |
Fri, 27 Jan 2017 17:07:33 +0000 |
User-agent: |
mu4e 0.9.19; emacs 25.1.91.4 |
Pranith Kumar <address@hidden> writes:
> On Fri, Jan 27, 2017 at 5:35 AM, Alex Bennée <address@hidden> wrote:
>
>> diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
>> index 21d96ec35c..536190f647 100644
>> --- a/tcg/i386/tcg-target.h
>> +++ b/tcg/i386/tcg-target.h
>> @@ -165,4 +165,20 @@ static inline void flush_icache_range(uintptr_t start,
>> uintptr_t stop)
>> {
>> }
>>
>> +/* This defines the natural memory order supported by this
>> + * architecture before guarantees made by various barrier
>> + * instructions.
>> + *
>> + * The x86 has a pretty strong memory ordering which only really
>> + * allows for some stores to be re-ordered after loads.
>> + */
>> +#include "tcg-mo.h"
>> +
>> +static inline int get_tcg_target_mo(void)
>> +{
>> + return TCG_MO_ALL & ~TCG_MO_LD_ST;
>> +}
>> +
>
> s/TCG_MO_LD_ST/TCG_MO_ST_LD/?
Doh - sorry I missed that. Will fix this time ;-)
>
> Thanks,
--
Alex Bennée