[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 3/6] arm: kvm64: Check if kvm sup
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 3/6] arm: kvm64: Check if kvm supports cross type vCPU |
|
Date: |
Sun, 29 Jan 2017 20:42:14 +0000 |
On 29 January 2017 at 11:53, Andrew Jones <address@hidden> wrote:
> On Mon, Jan 16, 2017 at 05:26:58PM +0800, Shannon Zhao wrote:
>> From: Shannon Zhao <address@hidden>
>> + memset(id_regitsers, 0, ARM_CPU_ID_MAX * sizeof(struct kvm_one_reg));
>> +
>> + id_regitsers[0].id = ARM64_SYS_REG(ARM_CPU_ID_MIDR);
>> + id_regitsers[0].addr = (uintptr_t)&cpu->midr;
>> +
>> + id_regitsers[1].id = ARM64_SYS_REG(ARM_CPU_ID_REVIDR);
>> + id_regitsers[1].addr = (uintptr_t)&cpu->revidr;
>> +
>
> We can condense this nicely with list initialization
>
> struct kvm_one_reg id_regitsers[] = {
> { ARM64_SYS_REG(ARM_CPU_ID_MIDR), (uintptr_t)&cpu->midr },
> { ARM64_SYS_REG(ARM_CPU_ID_REVIDR), (uintptr_t)&cpu->revidr },
> ...
> { 0, 0 }
"registers", please :-)
thanks
-- PMM
- [Qemu-arm] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 1/6] headers: update linux headers, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 6/6] target-arm: cpu64: Add support for Cortex-A72, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 5/6] arm: virt: Enable generic type CPU in virt machine, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 4/6] target: arm: Add a generic type cpu, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 2/6] target: arm: Add the qemu target for KVM_ARM_TARGET_GENERIC_V8, Shannon Zhao, 2017/01/16
- [Qemu-arm] [PATCH RFC 3/6] arm: kvm64: Check if kvm supports cross type vCPU, Shannon Zhao, 2017/01/16
- Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support, no-reply, 2017/01/16