[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variabl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-arm] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability |
|
Date: |
Mon, 6 Mar 2017 14:03:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 06/03/2017 10:46, Peter Maydell wrote:
> On 6 March 2017 at 04:06, Philippe Mathieu-Daudé <address@hidden> wrote:
>> your change seems OK but while you are here, 'unsigned' is considered
>> harmful since more than a decade.
>
> Considered harmful by who, and why?
It is true that unsigned has all the disadvantages of "int" (it may be
smaller than the size of the object" and all the disadvantages of
"size_t" (it doesn't optimize as well because the compiler cannot
exploit undefined behavior).
I wouldn't call it harmful, but it feels like the worst of both worlds.
Paolo
Re: [Qemu-arm] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report(), Philippe Mathieu-Daudé, 2017/03/05
Re: [Qemu-arm] [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report(), Eric Blake, 2017/03/06