qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [RFC 3/7] pci: Change pci_bus_new*() parameter to PCIHost


From: Eduardo Habkost
Subject: Re: [Qemu-arm] [RFC 3/7] pci: Change pci_bus_new*() parameter to PCIHostState
Date: Tue, 18 Apr 2017 10:30:05 -0300
User-agent: Mutt/1.8.0 (2017-02-23)

On Tue, Apr 18, 2017 at 04:27:23PM +0300, Marcel Apfelbaum wrote:
[...]
> > @@ -431,7 +430,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const 
> > char *name,
> >  {
> >      PCIBus *bus;
> > 
> > -    bus = pci_bus_new(parent, name, address_space_mem,
> > +    bus = pci_bus_new(PCI_HOST_BRIDGE(parent), name, address_space_mem,
> 
> If you request the parent to be PCI_HOST_BRIDGE, why don't you change also 
> the signature of
> pci_register_bus ?

I do it on patch 4/7.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]