qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx


From: Richard Henderson
Subject: Re: [Qemu-arm] [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values
Date: Wed, 26 Apr 2017 12:07:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/24/2017 06:33 PM, Peter Maydell wrote:
Overall questions:
  * does this look like it's workable enough to justify taking
    it rather than the simple-but-worse-perf-on-some-archs
    option 1 ?

I think it's workable.

  * this does risk breaking A profile in corner cases, because
    C unfortunately doesn't typecheck int vs enum so if I forgot
    a call to an index conversion function somewhere things will
    break. are we happy the risk isn't too huge?

If you like, we could add a tcg_debug assert somewhere that verifies that the given index is < NB_MMU_MODES...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]