Re: [Qemu-arm] [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <address@hidden>
> Acked-by: David Gibson <address@hidden> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <address@hidden> [SPARC part]
> Reviewed-by: Cornelia Huck <address@hidden> [s390x parts]
>
> ---
> v8: rebase later in series

That turned out nicely.  Thanks!

Reviewed-by: Markus Armbruster <address@hidden>