John Bradley
Tel: 07896 839635
Skype: flypie125
125B Grove Street
Edge Hill
Liverpool L7 7AF
On Wednesday, 17 May 2017, 19:27, Eric Blake <address@hidden> wrote:
On 05/17/2017 01:09 PM, John Bradley via Qemu-devel wrote:
> Also available at
>
This content belongs...
>
> Following suggestions split my original patch up. This the largest monolithic chunk is
> additional BCM device support from Markus Armbruster.
>
>
>>From 0b39a04030d5a2cea4fcd2159d365580ca155b78 Mon Sep 17 00:00:00 2001
> From: John Bradley <address@hidden>
> Date: Wed, 17 May 2017 18:57:21 +0100
> Subject: [PATCH] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.
>
> Signed-off-by: John Bradley <address@hidden>
I would expect that if some of this code was written by Markus, then it
would carry his Signed-off-by. Or, maybe you just mean that you are
splitting your patch according to the device Markus gave (in which case,
a Suggested-by: tag may be appropriate). Either way, I don't see why
Markus' name has to be in the subject line (the patch subject should be
WHAT changed, not WHO suggested the change).
> ---
...here, after the --- separator. It is useful to reviewers, but should
not end up as part of the actual commit message.
> hw/arm/Makefile.objs | 2 +-
> hw/arm/bcm2835.c | 114 ++++
> hw/arm/bcm2835_peripherals.c | 104 ++++
> hw/misc/Makefile.objs | 2 +
> hw/misc/bcm2835_mphi.c | 163 ++++++
> hw/misc/bcm2835_power.c | 106 ++++
> hw/timer/Makefile.objs | 2 +
> hw/timer/bcm2835_st.c | 202 +++++++
> hw/timer/bcm2835_timer.c | 224 +++++++
> hw/usb/Makefile.objs | 4 +-
> hw/usb/bcm2835_usb.c | 604 +++++++++++++++++++
> hw/usb/bcm2835_usb_regs.h | 1061 ++++++++++++++++++++++++++++++++++
That's still rather large to review in one chunk, especially while
touching other files. It can probably still be split up further.
> include/hw/arm/bcm2835.h | 37 ++
> include/hw/arm/bcm2835_peripherals.h | 10 +
> include/hw/intc/bcm2835_control.h | 53 ++
> include/hw/misc/bcm2835_mphi.h | 28 +
> include/hw/misc/bcm2835_power.h | 22 +
> include/hw/timer/bcm2835_st.h | 25 +
> include/hw/timer/bcm2835_timer.h | 32 +
> include/hw/usb/bcm2835_usb.h | 78 +++
> 20 files changed, 2871 insertions(+), 2 deletions(-)
> create mode 100644 hw/arm/bcm2835.c
> create mode 100644 hw/misc/bcm2835_mphi.c
> create mode 100644 hw/misc/bcm2835_power.c
> create mode 100644 hw/timer/bcm2835_st.c
> create mode 100644 hw/timer/bcm2835_timer.c
> create mode 100644 hw/usb/bcm2835_usb.c
> create mode 100644 hw/usb/bcm2835_usb_regs.h
> create mode 100644 include/hw/arm/bcm2835.h
> create mode 100644 include/hw/intc/bcm2835_control.h
> create mode 100644 include/hw/misc/bcm2835_mphi.h
> create mode 100644 include/hw/misc/bcm2835_power.h
> create mode 100644 include/hw/timer/bcm2835_st.h
> create mode 100644 include/hw/timer/bcm2835_timer.h
> create mode 100644 include/hw/usb/bcm2835_usb.h
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org