[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formating
|
From: |
no-reply |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. |
|
Date: |
Mon, 22 May 2017 16:56:48 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c33a1f7 GDummyPanel Fix formatingissues.
=== OUTPUT BEGIN ===
Checking PATCH 1/1: GDummyPanel Fix formatingissues....
ERROR: space prohibited between function name and open parenthesis '('
#37: FILE: hw/gpio/bcm2835_gpio.c:60:
+ if (index < sizeof (s->fsel)) {
ERROR: space prohibited between function name and open parenthesis '('
#46: FILE: hw/gpio/bcm2835_gpio.c:72:
+ if (index < sizeof (s->fsel)) {
ERROR: space prohibited after that '~' (ctx:WxW)
#97: FILE: hw/gpio/bcm2835_gpio.c:115:
+ uint32_t changes = val & ~ *lev;
^
ERROR: switch and case should be at the same indent
#122: FILE: hw/gpio/bcm2835_gpio.c:152:
switch (offset) {
+ case GPFSEL0:
+ case GPFSEL1:
+ case GPFSEL2:
+ case GPFSEL3:
+ case GPFSEL4:
+ case GPFSEL5:
[...]
+ case GPSET0:
+ case GPSET1:
[...]
+ case GPCLR0:
+ case GPCLR1:
[...]
+ case GPLEV0:
[...]
+ case GPLEV1:
[...]
+ case GPEDS0:
+ case GPEDS1:
+ case GPREN0:
+ case GPREN1:
+ case GPFEN0:
+ case GPFEN1:
+ case GPHEN0:
+ case GPHEN1:
+ case GPLEN0:
+ case GPLEN1:
+ case GPAREN0:
+ case GPAREN1:
+ case GPAFEN0:
+ case GPAFEN1:
+ case GPPUD:
+ case GPPUDCLK0:
+ case GPPUDCLK1:
[...]
+ default:
ERROR: switch and case should be at the same indent
#232: FILE: hw/gpio/bcm2835_gpio.c:219:
switch (offset) {
+ case GPFSEL0:
+ case GPFSEL1:
+ case GPFSEL2:
+ case GPFSEL3:
+ case GPFSEL4:
+ case GPFSEL5:
[...]
+ case GPSET0:
[...]
+ case GPSET1:
[...]
+ case GPCLR0:
[...]
+ case GPCLR1:
[...]
+ case GPLEV0:
+ case GPLEV1:
[...]
+ case GPEDS0:
+ case GPEDS1:
+ case GPREN0:
+ case GPREN1:
+ case GPFEN0:
+ case GPFEN1:
+ case GPHEN0:
+ case GPHEN1:
+ case GPLEN0:
+ case GPLEN1:
+ case GPAREN0:
+ case GPAREN1:
+ case GPAFEN0:
+ case GPAFEN1:
+ case GPPUD:
+ case GPPUDCLK0:
+ case GPPUDCLK1:
[...]
+ default:
WARNING: line over 80 characters
#364: FILE: hw/gpio/bcm2835_gpio.c:316:
+ .endianness =
DEVICE_NATIVE_ENDIAN,
WARNING: line over 80 characters
#380: FILE: hw/gpio/bcm2835_gpio.c:323:
+ .fields =
(VMStateField[])
ERROR: space prohibited between function name and open parenthesis '('
#395: FILE: hw/gpio/bcm2835_gpio.c:339:
+ qbus_create_inplace(&s->sdbus, sizeof (s->sdbus),
WARNING: line over 80 characters
#449: FILE: hw/gpio/bcm2835_gpio.c:397:
+ .instance_size = sizeof
(BCM2835GpioState),
ERROR: space prohibited between function name and open parenthesis '('
#449: FILE: hw/gpio/bcm2835_gpio.c:397:
+ .instance_size = sizeof
(BCM2835GpioState),
WARNING: line over 80 characters
#451: FILE: hw/gpio/bcm2835_gpio.c:399:
+ .class_init =
bcm2835_gpio_class_init,
WARNING: architecture specific defines should be avoided
#499: FILE: include/qemu/PanelEmu.h:17:
+#ifdef __cplusplus
ERROR: code indent should never use tabs
#516: FILE: include/qemu/PanelEmu.h:34:
+^I unless something changed */$
WARNING: architecture specific defines should be avoided
#530: FILE: include/qemu/PanelEmu.h:48:
+#ifdef __cplusplus
WARNING: architecture specific defines should be avoided
#564: FILE: util/PanelEmu.c:13:
+#ifdef __MINGW32__
ERROR: open brace '{' following enum go on the same line
#575: FILE: util/PanelEmu.c:24:
+typedef enum
+{
ERROR: open brace '{' following struct go on the same line
#596: FILE: util/PanelEmu.c:45:
+typedef struct
+{
WARNING: architecture specific defines should be avoided
#697: FILE: util/PanelEmu.c:146:
+#ifdef __MINGW32__
ERROR: spaces required around that '&&' (ctx:VxO)
#730: FILE: util/PanelEmu.c:179:
+ while (NoError&&! NoData) {
^
ERROR: space prohibited after that '!' (ctx:OxW)
#730: FILE: util/PanelEmu.c:179:
+ while (NoError&&! NoData) {
^
ERROR: space prohibited before that '++' (ctx:WxB)
#739: FILE: util/PanelEmu.c:188:
+ for (int i = 0; LengthInBuffer > 0; i ++) {
^
ERROR: space prohibited before that '++' (ctx:WxB)
#769: FILE: util/PanelEmu.c:218:
+ for (int j = 0; j < LengthInBuffer; j ++) {
^
WARNING: architecture specific defines should be avoided
#790: FILE: util/PanelEmu.c:239:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#810: FILE: util/PanelEmu.c:259:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#818: FILE: util/PanelEmu.c:267:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#827: FILE: util/PanelEmu.c:276:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#835: FILE: util/PanelEmu.c:284:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#849: FILE: util/PanelEmu.c:298:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#866: FILE: util/PanelEmu.c:315:
+#ifdef __MINGW32__
WARNING: architecture specific defines should be avoided
#874: FILE: util/PanelEmu.c:323:
+#ifdef __MINGW32__
total: 14 errors, 16 warnings, 820 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden