[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v11 29/29] target/arm: [tcg] Port to
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v11 29/29] target/arm: [tcg] Port to generic translation framework |
|
Date: |
Fri, 07 Jul 2017 13:26:23 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Richard Henderson writes:
> On 06/28/2017 07:13 AM, Lluís Vilanova wrote:
>> @@ -11377,6 +11385,9 @@ static void aarch64_trblock_tb_stop(DisasContextBase
>> *dcbase, CPUState *cpu)
>> break;
>> }
>> }
>> +
>> + /* Functions above can change dc->pc, so re-align db->pc_next */
>> + dc->base.pc_next = dc->pc;
>> }
>> static void aarch64_trblock_disas_log(const DisasContextBase *dcbase,
> Surely this belonged in a previous patch.
No, there's pieces of the previous loop that used dc->pc (calculation of
tb->size at the end), and the generic one only has dc->base.pc_next now.
Thanks,
Lluis