Re: [Qemu-arm] [PATCH v12 03/27] target: [tcg] Use a generic enum for DISAS_ values

[Richard Henderson]

On 07/11/2017 11:10 PM, Alex Bennée wrote:
> > +typedef enum DisasJumpType {
> > +    DISAS_NEXT,
> > +    DISAS_TOO_MANY,
>
> Is DISAS_TOO_MANY really a useful distinction. Sure we have ended the
> loop because of an instruction limit but the more important information
> is what it means for the epilogue code and how we go to the next block.

Yes. I think it is.

The reason is that it is the way that the generic loop can tell the target hook 
that it terminated the instruction fetch loop.  There may (or may not) be 
something special that the target needs to do for that specific case.


r~