Re: [Qemu-arm] [Qemu-devel] [PATCH v2 0/9] ARM: implement MPS2 board (with 2 FPGA flavours)

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/9] ARM: implement MPS2 board (with 2 FPGA 
flavours)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f3b7511 MAINTAINERS: Add entries for MPS2 board
7b2658f hw/arm/mps2: Add ethernet
62c2290 hw/arm/mps2: Add SCC
ef531fe hw/misc/mps2_scc: Implement MPS2 Serial Communication Controller
1410c25 hw/arm/mps2: Add timers
be73385 hw/char/cmsdk-apb-timer: Implement CMSDK APB timer device
fe7d5af hw/arm/mps2: Add UARTs
d9f622a hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART
1d6f3c6 hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 board models

=== OUTPUT BEGIN ===
Checking PATCH 1/9: hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 
board models...
ERROR: line over 90 characters
#72: FILE: hw/arm/mps2.c:22:
+ *   
https://developer.arm.com/products/system-design/development-boards/cortex-m-prototyping-system

total: 1 errors, 0 warnings, 282 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/9: hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART...
ERROR: line over 90 characters
#57: FILE: hw/char/cmsdk-apb-uart.c:15:
+ * 
https://developer.arm.com/products/system-design/system-design-kits/cortex-m-system-design-kit

total: 1 errors, 0 warnings, 507 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/9: hw/arm/mps2: Add UARTs...
Checking PATCH 4/9: hw/char/cmsdk-apb-timer: Implement CMSDK APB timer device...
ERROR: line over 90 characters
#56: FILE: hw/timer/cmsdk-apb-timer.c:15:
+ * 
https://developer.arm.com/products/system-design/system-design-kits/cortex-m-system-design-kit

total: 1 errors, 0 warnings, 331 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/9: hw/arm/mps2: Add timers...
Checking PATCH 6/9: hw/misc/mps2_scc: Implement MPS2 Serial Communication 
Controller...
ERROR: line over 90 characters
#69: FILE: hw/misc/mps2-scc.c:16:
+ * 
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.100112_0100_03_en/index.html

ERROR: spaces required around that '*' (ctx:WxV)
#104: FILE: hw/misc/mps2-scc.c:51:
+static bool scc_cfg_write(MPS2SCC *s, unsigned function,
                                   ^

total: 2 errors, 0 warnings, 379 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/9: hw/arm/mps2: Add SCC...
Checking PATCH 8/9: hw/arm/mps2: Add ethernet...
Checking PATCH 9/9: MAINTAINERS: Add entries for MPS2 board...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden