[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 06/15] target/arm: Remove incorrect comment about
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH 06/15] target/arm: Remove incorrect comment about MPU_CTRL |
Date: |
Thu, 3 Aug 2017 17:24:08 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Aug 02, 2017 at 05:43:52PM +0100, Peter Maydell wrote:
> Remove the comment that claims that some MPU_CTRL bits are stored
> in sctlr_el[1]. This has never been true since MPU_CTRL was added
> in commit 29c483a50607 -- the comment is a leftover from
> Michael Davidsaver's original implementation, which I modified
> not to use sctlr_el[1]; I forgot to delete the comment then.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target/arm/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index b39d64a..b64474c 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -416,7 +416,7 @@ typedef struct CPUARMState {
> uint32_t dfsr; /* Debug Fault Status Register */
> uint32_t mmfar; /* MemManage Fault Address */
> uint32_t bfar; /* BusFault Address */
> - unsigned mpu_ctrl; /* MPU_CTRL (some bits kept in sctlr_el[1]) */
> + unsigned mpu_ctrl; /* MPU_CTRL */
> int exception;
> } v7m;
>
> --
> 2.7.4
>
>