[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v1 1/3] target/arm: Update the memops for exclusiv
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH v1 1/3] target/arm: Update the memops for exclusive load |
Date: |
Sat, 12 Aug 2017 13:38:26 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Aug 11, 2017 at 03:17:36PM -0700, Alistair Francis wrote:
> Acording to the ARM ARM exclusive loads require the same allignment as
> exclusive stores. Let's update the memops used for the load to match
> that of the store. This adds the alignment requirement to the memops.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
>
> target/arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 58ed4c6d05..245175e2f1 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -1854,7 +1854,7 @@ static void gen_load_exclusive(DisasContext *s, int rt,
> int rt2,
> TCGv_i64 addr, int size, bool is_pair)
> {
> TCGv_i64 tmp = tcg_temp_new_i64();
> - TCGMemOp memop = s->be_data + size;
> + TCGMemOp memop = size | MO_ALIGN | s->be_data;
>
> g_assert(size <= 3);
> tcg_gen_qemu_ld_i64(tmp, addr, get_mem_index(s), memop);
> --
> 2.11.0
>
- [Qemu-arm] [PATCH v1 0/3] Fixup exclusive store logic, Alistair Francis, 2017/08/11
- [Qemu-arm] [PATCH v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions, Alistair Francis, 2017/08/11
- [Qemu-arm] [PATCH v1 1/3] target/arm: Update the memops for exclusive load, Alistair Francis, 2017/08/11
- Re: [Qemu-arm] [PATCH v1 1/3] target/arm: Update the memops for exclusive load,
Edgar E. Iglesias <=
- [Qemu-arm] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask, Alistair Francis, 2017/08/11
- Re: [Qemu-arm] [PATCH v1 0/3] Fixup exclusive store logic, Alistair Francis, 2017/08/11
- Re: [Qemu-arm] [PATCH v1 0/3] Fixup exclusive store logic, Peter Maydell, 2017/08/12