|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-arm] [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries |
Date: | Wed, 30 Aug 2017 18:14:33 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 07/28/2017 03:55 AM, Thomas Huth wrote:
On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote:Signed-off-by: Philippe Mathieu-Daudé <address@hidden> --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 972118e70b..795f89f709 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -120,6 +120,8 @@ F: include/hw/cpu/a*mpcore.h F: disas/arm.c F: disas/arm-a64.cc F: disas/libvixl/ +F: default-configs/arm-softmmu.mak +F: default-configs/aarch64-softmmu.makYou've added this to the TCG CPU core section, but strictly speaking these files are also used for the machine emulation in general (and also for KVM). So not sure whether this is a good fit here ... up to Peter to decide.
You are right.
CRIS M: Edgar E. Iglesias <address@hidden> @@ -380,6 +382,7 @@ M: Peter Maydell <address@hidden> L: address@hidden S: Maintained F: hw/char/pl011.c +F: include/hw/char/pl011.h F: hw/display/pl110* F: hw/dma/pl080.c F: hw/dma/pl330.c @@ -402,14 +405,19 @@ F: hw/intc/arm* F: hw/intc/gic_internal.h F: hw/misc/a9scu.c F: hw/misc/arm11scu.c +F: hw/misc/arm_sysctl.cAccording to a comment in that file, it is about RealView/Versatile boards instead, so this is the wrong section here?
Wrong section indeed.
F: hw/timer/a9gtimer* F: hw/timer/arm_* +F: hw/timer/armv7m_systick.cHow about rather removing the underscore in the previous wildcard entry?
I also wondered, because I'm a slowly working branch where I try to boot some Marvell SoC, and I named the timer "armada_timer.c" following the Linux device-tree naming:
https://www.kernel.org/doc/Documentation/devicetree/bindings/timer/marvell%2Carmada-370-xp-timer.txtBut if I ever finish it I can add an exclude entry, so I'll follow your advice.
F: include/hw/arm/arm.h +F: include/hw/arm/armv7m*.h F: include/hw/intc/arm* F: include/hw/misc/a9scu.h F: include/hw/misc/arm11scu.h F: include/hw/timer/a9gtimer.h F: include/hw/timer/arm_mptimer.h +F: include/hw/timer/armv7m_systick.h +F: tests/test-arm-mptimer.cExynosM: Igor Mitsyanko <address@hidden>Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |