Re: [Qemu-arm] [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete

[Richard Henderson]

On 09/12/2017 01:14 PM, Peter Maydell wrote:
> Update armv7m_nvic_acknowledge_irq() and armv7m_nvic_complete_irq()
> to handle banked exceptions:
>  * acknowledge needs to use the correct vector, which may be
>    in sec_vectors[]
>  * acknowledge needs to return to its caller whether the
>    exception should be taken to secure or non-secure state
>  * complete needs its caller to tell it whether the exception
>    being completed is a secure one or not
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/arm/cpu.h      | 15 +++++++++++++--
>  hw/intc/armv7m_nvic.c | 26 ++++++++++++++++++++------
>  target/arm/helper.c   |  8 +++++---
>  hw/intc/trace-events  |  4 ++--
>  4 files changed, 40 insertions(+), 13 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

r~