[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 02/13] target/arm: Check PMCNTEN for whether PMCCN
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH 02/13] target/arm: Check PMCNTEN for whether PMCCNTR is enabled |
Date: |
Tue, 17 Oct 2017 13:49:56 +0100 |
On 30 September 2017 at 03:08, Aaron Lindsay <address@hidden> wrote:
> Signed-off-by: Aaron Lindsay <address@hidden>
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 8be78ea..40c9273 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -964,7 +964,7 @@ static inline bool arm_ccnt_enabled(CPUARMState *env)
> {
> /* This does not support checking PMCCFILTR_EL0 register */
>
> - if (!(env->cp15.c9_pmcr & PMCRE)) {
> + if (!(env->cp15.c9_pmcr & PMCRE) || !(env->cp15.c9_pmcnten & (1 << 31)))
> {
> return false;
> }
>
Reviewed-by: Peter Maydell <address@hidden>
I keep replying to your v1 patchset by mistake -- can you use
the git format-patch options to put make the subject prefix
be "[PATCH v3]" for the next round in all the patchmails to
help keep the versions distinct, please?
thanks
-- PMM