Re: [Qemu-arm] [PATCH v5 7/8] misc: add pca9552 LED blinker model

[Peter Maydell]

On 19 October 2017 at 16:12, Cédric Le Goater <address@hidden> wrote:
> Specs are available here :
>
>     https://www.nxp.com/docs/en/application-note/AN264.pdf
>
> This is a simple model supporting the basic registers for led and GPIO
> mode. The device also supports two blinking rates but not the model
> yet.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
>
>  Changes since v3:
>
>  - introduced auto-increment support
>  - removed the buffer collecting bytes on the bus
>  - improved reset
>  - used extract32
>  - added a unit test
>
>  Changes since v2:
>
>  - removed comments on the I2C buffer size, but kept the array. I did
>    not want to rewrite the buffer handling
>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM