[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 8/8] aspeed: add the pc9552 chips to the wither
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine |
Date: |
Thu, 19 Oct 2017 23:59:49 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/19/2017 01:35 PM, Cédric Le Goater wrote:
> The pca9552 LED blinkers on the Witherspoon machine are used for leds
> but also as GPIOs to control fans and GPUs.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> Reviewed-by: Andrew Jeffery <address@hidden>
> ---
> hw/arm/aspeed.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index df7f266800ba..0e2a4fa62c26 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -397,6 +397,8 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState
> *bmc)
> AspeedSoCState *soc = &bmc->soc;
> uint8_t *eeprom_buf = g_malloc0(8 * 1024);
>
> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 3), "pca9552",
> 0x60);
TYPE_PCA9552 ?
> +
> i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), "tmp423",
> 0x4c);
> i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), "tmp423",
> 0x4c);
>
> @@ -409,6 +411,8 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState
> *bmc)
>
> smbus_eeprom_init_one(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), 0x51,
> eeprom_buf);
> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), "pca9552",
ditto
> + 0x60);
> }
>
> static void witherspoon_bmc_init(MachineState *machine)
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-arm] [PATCH v6 1/8] aspeed: use a ROM memory region to catch invalid writes, (continued)
- [Qemu-arm] [PATCH v6 1/8] aspeed: use a ROM memory region to catch invalid writes, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 2/8] aspeed: remove ignore_memory_transaction_failures on all boards, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 3/8] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 4/8] aspeed: add an I2C RTC device to all machines, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 5/8] smbus: add a smbus_eeprom_init_one() routine, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 6/8] aspeed: Add EEPROM I2C devices, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 7/8] misc: add pca9552 LED blinker model, Cédric Le Goater, 2017/10/19
- [Qemu-arm] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine, Cédric Le Goater, 2017/10/19
- Re: [Qemu-arm] [PATCH v6 8/8] aspeed: add the pc9552 chips to the witherspoon machine,
Philippe Mathieu-Daudé <=