Re: [Qemu-arm] [PATCH 0/4] softfloat: fix some helper definitions

[Philippe Mathieu-Daudé]

Hi Laurent,

On 11/03/2017 05:26 PM, Laurent Vivier wrote:
> This series fixes some errors found by
> enabling USE_SOFTFLOAT_STRUCT_TYPES.
> 
> Most of them are helpers using int types
> instead of float types.
> This also requires the use of floatXX_val()
> and make_floatXX().
> 
> Laurent Vivier (4):
>   arm: fix float64 helper definitions
>   openrisc: fix float32 and float64 helper definitions
>   tricore: use make_float32() and float32_val()
>   softfloat: use floatXX_val() in XX_minmax()
> 
>  fpu/softfloat.c              |  8 +++----
>  target/arm/helper-a64.h      |  6 ++---
>  target/openrisc/fpu_helper.c | 52 
> ++++++++++++++++++++++----------------------
>  target/openrisc/helper.h     | 20 ++++++++---------
>  target/tricore/fpu_helper.c  | 34 ++++++++++++++---------------
>  5 files changed, 60 insertions(+), 60 deletions(-)
> 

I'm getting those errors:

$ make subdir-arm-softmmu -j2

/source/qemu/migration/vmstate-types.c:430:5: error: conversion to
non-scalar type requested
     qemu_put_be64(f, float64_val(*v));
     ^~~~~~~~~~~~~
make: *** [migration/vmstate-types.o] Error 1

In file included from /source/qemu/fpu/softfloat.c:87:0:
/source/qemu/fpu/softfloat-specialize.h: In function ‘float16_default_nan’:
/source/qemu/include/fpu/softfloat.h:117:26: error: expected expression
before ‘{’ token
 #define const_float16(x) { x }
                          ^
/source/qemu/fpu/softfloat-specialize.h:95:12: note: in expansion of
macro ‘const_float16’
     return const_float16(0x7E00);
            ^~~~~~~~~~~~~
make: *** [fpu/softfloat.o] Error 1