[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] hw/intc/arm_gicv3_its: Fix the VM termination in
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-arm] [PATCH] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler() |
|
Date: |
Mon, 6 Nov 2017 10:38:24 +0000 |
On 6 November 2017 at 07:30, Auger Eric <address@hidden> wrote:
> Hi Shanker,
>
> On 03/11/2017 13:37, Shanker Donthineni wrote:
>> The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save
>> /restore") breaks the backward compatibility with the older kernels
>> where vITS save/restore support is not available. The vmstate function
>> vm_change_state_handler() should not be registered if the running kernel
>> doesn't support ITS save/restore feature. Otherwise VM instance will be
>> killed whenever vmstate callback function is invoked.
>>
>> Observed a virtual machine shutdown with QEMU-2.10+linux-4.11 when testing
>> the reboot command "virsh reboot <domain> --mode acpi" instead of reboot.
>>
>> KVM Error: 'KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x00000000000001'
>>
>> Signed-off-by: Shanker Donthineni <address@hidden>
> Reviewed-by: Eric Auger <address@hidden>
Applied to target-arm.next, thanks.
-- PMM