Re: [Qemu-arm] [Qemu-devel] [PATCH v7 4/5] arm: kinetis_k64_system

[Peter Maydell]

On 27 October 2017 at 13:24, Gabriel Costa <address@hidden> wrote:
> This Patch include kinetis_k64_system.c/.h and Makefile.objs
> sim means System Integration Module (SIM)
> More information about this peripheral can be found at:
> pag 291, K64P144M120SF5RM.pdf.
>
> Signed-off-by: Gabriel Augusto Costa <address@hidden>
> ---
>  hw/misc/Makefile.objs                |   3 +
>  hw/misc/kinetis_k64_system.c         | 274 
> +++++++++++++++++++++++++++++++++++
>  include/hw/misc/kinetis_k64_system.h |  52 +++++++
>  3 files changed, 329 insertions(+)
>  create mode 100644 hw/misc/kinetis_k64_system.c
>  create mode 100644 include/hw/misc/kinetis_k64_system.h
>
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index 19202d9..c5c8589 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -61,3 +61,6 @@ obj-$(CONFIG_AUX) += auxbus.o
>  obj-$(CONFIG_ASPEED_SOC) += aspeed_scu.o aspeed_sdmc.o
>  obj-y += mmio_interface.o
>  obj-$(CONFIG_MSF2) += msf2-sysreg.o
> +obj-$(CONFIG_KINETIS_K64) += kinetis_k64_mcg.o
> +obj-$(CONFIG_KINETIS_K64) += kinetis_k64_pmux.o
> +obj-$(CONFIG_KINETIS_K64) += kinetis_k64_system.o
> diff --git a/hw/misc/kinetis_k64_system.c b/hw/misc/kinetis_k64_system.c
> new file mode 100644
> index 0000000..e547fe8
> --- /dev/null
> +++ b/hw/misc/kinetis_k64_system.c
> @@ -0,0 +1,274 @@
> +/*
> + * Kinetis K64 peripheral microcontroller emulation.
> + *
> + * Copyright (c) 2017 Advantech Wireless
> + * Written by Gabriel Costa <address@hidden>
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 or
> + *  (at your option) any later version.
> + */

Looks like the same comments apply here as for the other devices:
 * coding conventions
 * read-only registers
 * read-only bits in registers

thanks
-- PMM