[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full rese
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full reset |
Date: |
Tue, 28 Nov 2017 16:04:12 +0000 |
On 28 November 2017 at 15:41, Eric Auger <address@hidden> wrote:
> Voiding the ITS caches is not supposed to happen via
> individual register writes. So we introduced a dedicated
> ITS KVM device ioctl to perform a cold reset of the ITS:
> KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_ITS_CTRL_RESET. Let's
> use this latter if the kernel supports it.
>
> Signed-off-by: Eric Auger <address@hidden>
> ---
> hw/intc/arm_gicv3_its_kvm.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
> index 1c663ac..bf290b8 100644
> --- a/hw/intc/arm_gicv3_its_kvm.c
> +++ b/hw/intc/arm_gicv3_its_kvm.c
> @@ -204,7 +204,14 @@ static void kvm_arm_its_reset(DeviceState *dev)
>
> c->parent_reset(dev);
>
> - error_report("ITS KVM: full reset is not supported by QEMU");
> + if (kvm_device_check_attr(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_CTRL,
> + KVM_DEV_ARM_ITS_CTRL_RESET)) {
> + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_CTRL,
> + KVM_DEV_ARM_ITS_CTRL_RESET, NULL, true,
> &error_abort);
> + return;
> + }
> +
> + error_report("ITS KVM: full reset is not supported by the host kernel");
>
> if (!kvm_device_check_attr(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_ITS_REGS,
> GITS_CTLR)) {
> --
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-arm] [PATCH v6 0/4] vITS Reset, Eric Auger, 2017/11/28
- [Qemu-arm] [PATCH v6 1/4] hw/intc/arm_gicv3_its: Don't call post_load on reset, Eric Auger, 2017/11/28
- [Qemu-arm] [PATCH v6 2/4] hw/intc/arm_gicv3_its: Implement a minimalist reset, Eric Auger, 2017/11/28
- [Qemu-arm] [PATCH v6 3/4] linux-headers: update to 4.15-rc1, Eric Auger, 2017/11/28
- [Qemu-arm] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full reset, Eric Auger, 2017/11/28
- Re: [Qemu-arm] [PATCH v6 4/4] hw/intc/arm_gicv3_its: Implement full reset,
Peter Maydell <=
- Re: [Qemu-arm] [PATCH v6 0/4] vITS Reset, Peter Maydell, 2017/11/29