Re: [Qemu-arm] [PATCH v14 1/9] ACPI: add some GHES structures and macros definition

[gengdongjiu]

[...]
> > +/*
> >   * MADT sub-structures (Follow MULTIPLE_APIC_DESCRIPTION_TABLE)
> >   */
> >  #define ACPI_SUB_HEADER_DEF   /* Common ACPI sub-structure header */\
> > @@ -474,6 +493,39 @@ struct AcpiSystemResourceAffinityTable {  }
> > QEMU_PACKED;  typedef struct AcpiSystemResourceAffinityTable
> > AcpiSystemResourceAffinityTable;
> >
> > +/*
> > + * Generic Error Status Block
> > + */
> > +struct AcpiGenericErrorStatus {
> > +    /* It is a bitmask composed of ACPI_GEBS_xxx macros */
> > +    uint32_t block_status;
> > +    uint32_t raw_data_offset;
> > +    uint32_t raw_data_length;
> > +    uint32_t data_length;
> > +    uint32_t error_severity;
> > +} QEMU_PACKED;
> > +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus;
> > +
> > +/*
> > + * Masks for Block Status field above  */
> > +#define ACPI_GEBS_UNCORRECTABLE          (1)
> () are usually used with an expression and not with single value, so drop 
> that to be consistent with style of the header


Igor, sure, it is. I will drop it. Appreciate for your point out.

> 
> > +
> > +/*
> > + * Value for Error Severity field above  */ enum
> > +AcpiGenericErrorSeverity {
> > +    ACPI_CPER_SEV_RECOVERABLE,
> > +    ACPI_CPER_SEV_FATAL,
> > +    ACPI_CPER_SEV_CORRECTED,
> > +    ACPI_CPER_SEV_NONE,
> > +};
> > +
> > +/*
> > + * Generic Hardware Error Source version 2  */
> > +#define ACPI_HEST_SOURCE_GENERIC_ERROR_V2    (10)
> ditto


You are right, will drop it. Thanks you very much.

> 
> > +
> >  #define ACPI_SRAT_PROCESSOR_APIC     0
> >  #define ACPI_SRAT_MEMORY             1
> >  #define ACPI_SRAT_PROCESSOR_x2APIC   2
[...]