[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] target/arm/translate.c: Fix missing 'break' for T
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-arm] [PATCH] target/arm/translate.c: Fix missing 'break' for TT insns |
|
Date: |
Tue, 6 Feb 2018 09:01:19 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 02/06/2018 07:39 AM, Peter Maydell wrote:
> The code where we added the TT instruction was accidentally
"In 5158de241b0 ..."
> missing a 'break', which meant that after generating the code
> to execute the TT we would fall through to 'goto illegal_op'
> and generate code to take an UNDEF insn.>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Doh...
>
> target/arm/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 55826b7e5a..572c4d1cb6 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -9926,6 +9926,7 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t
> insn)
> tcg_temp_free_i32(addr);
> tcg_temp_free_i32(op);
> store_reg(s, rd, ttresp);
> + break;
> }
> goto illegal_op;
> }
>
signature.asc
Description: OpenPGP digital signature