[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII
From: |
Linus Walleij |
Subject: |
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022 |
Date: |
Tue, 27 Feb 2018 11:21:07 +0100 |
On Tue, Feb 27, 2018 at 11:09 AM, Peter Maydell
<address@hidden> wrote:
> On 27 February 2018 at 07:41, Linus Walleij <address@hidden> wrote:
>> On Sat, Feb 17, 2018 at 7:32 PM, Philippe Mathieu-Daudé <address@hidden>
>> wrote:
>>
>>> [Me]
>>>> +#define DEBUG_SII9022 0
>>>> +
>>>> +#define DPRINTF(fmt, ...) \
>>>> + do { \
>>>> + if (DEBUG_SII9022) { \
>>>> + printf("sii9022: " fmt, ## __VA_ARGS__); \
>>>> + } \
>>>> + } while (0)
>>>
>>> Can you replace DPRINTF() by trace events?
>>
>> Absolutely but which ones?
>>
>> I do not feel senior enough to also invent new trace events
>> for displays or I2C devices...
>
> Just put a trace event where you've put DPRINTF debug statements.
Yeah, hm the question might be silly or something but I don't
know how to do that.
I guess I should include "trace.h".
#include "trace.h" says it is autogenerated from tracetool.
Is there some documentation I should be reading or a good
example commit I can study to get the hang of it?
Yours,
Linus Walleij
Re: [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022, Peter Maydell, 2018/02/22
[Qemu-arm] [PATCH 3/3] arm/vexpress: Add proper display connector emulation, Linus Walleij, 2018/02/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH 3/3] arm/vexpress: Add proper display connector emulation, Philippe Mathieu-Daudé, 2018/02/17
- Re: [Qemu-arm] [Qemu-devel] [PATCH 3/3] arm/vexpress: Add proper display connector emulation, Linus Walleij, 2018/02/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH 3/3] arm/vexpress: Add proper display connector emulation, Corey Minyard, 2018/02/19
- [Qemu-arm] [PATCH 0/2] Move the bus class to i2c.h, minyard, 2018/02/19
- [Qemu-arm] [PATCH 2/2] i2c: Move the bus class to i2c.h, minyard, 2018/02/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h, Peter Maydell, 2018/02/19