Re: [Qemu-arm] [Qemu-devel] [PATCH v2 48/67] target/arm: Implement SVE floating-point arithmetic (predicated)

[Peter Maydell]

On 17 February 2018 at 18:23, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/helper-sve.h    |  77 ++++++++++++++++++++++++++++++++
>  target/arm/sve_helper.c    | 107 
> +++++++++++++++++++++++++++++++++++++++++++++
>  target/arm/translate-sve.c |  47 ++++++++++++++++++++
>  target/arm/sve.decode      |  17 +++++++
>  4 files changed, 248 insertions(+)

> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index a1e0ceb5fb..d80babfae7 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -2789,6 +2789,113 @@ uint32_t HELPER(sve_while)(void *vd, uint32_t count, 
> uint32_t pred_desc)
>      return predtest_ones(d, oprsz, esz_mask);
>  }
>
> +/* Fully general three-operand expander, controlled by a predicate,
> + * With the extra float_status parameter.

lower-case "w"

> @@ -3181,6 +3227,7 @@ static void do_zpz_ptr(DisasContext *s, int rd, int rn, 
> int pg,
>                         vec_full_reg_offset(s, rn),
>                         pred_full_reg_offset(s, pg),
>                         status, vsz, vsz, 0, fn);
> +    tcg_temp_free_ptr(status);
>  }

Shouldn't this be squashed into an earlier patch?

otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM