Re: [Qemu-arm] [PATCH v5 1/7] hw/mdio: Generalize etraxfs MDIO bitbanging emulation

[Grant Likely]

On 22/09/2017, 12:13, "Philippe Mathieu-Daudé"
<address@hidden on behalf of address@hidden> wrote:
> From: Grant Likely <address@hidden>
                                  ^^^^^^^^

Hi Philippe,

Just following up on this series. I don't really have any additional
comments. It has been many years since I looked at the code, so I'm
quite happy for you to have picked it up.

However, it is very important for you to preserve the original email
address that I used when I submitted the patches, and do *not* use my
arm.com address. None of this code is owned by Arm. Please change the
From: attribution and my SoB line to use "address@hidden"

Thanks,
g.

>    The etraxfs and Xilinx axienet Ethernet models implement quite a nice
>    MDIO core that supports both bitbanging and direct register access. This
>    change factors the common code out into a separate file. There are no
>    functional changes here, just movement of code.
>
>    The etraxfs and axienet are slightly different. The etraxfs version
>    includes the bitbang state processing, but the axienet version has a
>    minor enhancement for read/write of phy registers without using bitbang
>    state variables.  This patch generalizes the etraxfs version, with the
>    axienet change backported in.
>
>    Signed-off-by: Grant Likely <address@hidden>
>    Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>    [PMD: rebased with a minor checkpatch fix]