[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PULL 6/7] hw/cpu/cluster: Mark the cpu-cluster device with u
From: |
Laurent Vivier |
Subject: |
[Qemu-arm] [PULL 6/7] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false |
Date: |
Wed, 6 Feb 2019 16:28:06 +0100 |
From: Thomas Huth <address@hidden>
The device can not be instantiated by the user and QEMU currently
aborts when you try to use it:
$ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster
qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize:
Assertion `cbdata.cpu_count > 0' failed.
Aborted (core dumped)
Since this is an internal device only, mark it with user_creatable = false.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Luc Michel <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/cpu/cluster.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
index 25f90702b1..6f5f037b3c 100644
--- a/hw/cpu/cluster.c
+++ b/hw/cpu/cluster.c
@@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void
*data)
dc->props = cpu_cluster_properties;
dc->realize = cpu_cluster_realize;
+
+ /* This is not directly for users, CPU children must be attached by code */
+ dc->user_creatable = false;
}
static const TypeInfo cpu_cluster_type_info = {
--
2.20.1
- [Qemu-arm] [PULL 0/7] Trivial patches patches, Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 1/7] qemu-common.h: Update copyright string for 2019, Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 2/7] target/moxie: Fix LGPL information in the file headers, Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 3/7] configure: Avoid non-portable 'test -o/-a', Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 6/7] hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false,
Laurent Vivier <=
- [Qemu-arm] [PULL 7/7] hw/input/tsc210x: Fix building with no verbosity, Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 5/7] hw/unicore32/puv3: Drop useless inclusion of "hw/i386/pc.h", Laurent Vivier, 2019/02/06
- [Qemu-arm] [PULL 4/7] hw/sparc64/sun4u: Drop useless inclusion of "hw/i386/pc.h", Laurent Vivier, 2019/02/06
- Re: [Qemu-arm] [PULL 0/7] Trivial patches patches, Peter Maydell, 2019/02/07