[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 07/14] hw/char/pl011: Use '0x' prefix
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers |
Date: |
Mon, 18 Feb 2019 23:00:25 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/14/19 1:51 PM, Peter Maydell wrote:
> The pl011 logs when the guest makes a bad access. It prints
> the address offset in hex but confusingly omits the '0x'
> prefix; add it.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/char/pl011.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/char/pl011.c b/hw/char/pl011.c
> index 29f4e5eb224..e5dd448f854 100644
> --- a/hw/char/pl011.c
> +++ b/hw/char/pl011.c
> @@ -143,7 +143,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset,
> break;
> default:
> qemu_log_mask(LOG_GUEST_ERROR,
> - "pl011_read: Bad offset %x\n", (int)offset);
> + "pl011_read: Bad offset 0x%x\n", (int)offset);
> r = 0;
> break;
> }
> @@ -232,7 +232,7 @@ static void pl011_write(void *opaque, hwaddr offset,
> break;
> default:
> qemu_log_mask(LOG_GUEST_ERROR,
> - "pl011_write: Bad offset %x\n", (int)offset);
> + "pl011_write: Bad offset 0x%x\n", (int)offset);
> }
> }
>
>
- [Qemu-arm] [PATCH 04/14] hw/timer/pl031: Convert to using trace events, (continued)
- [Qemu-arm] [PATCH 04/14] hw/timer/pl031: Convert to using trace events, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 14/14] hw/arm/musca: Wire up PL011 UARTs, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 11/14] hw/arm/musca: Add PPCs, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 01/14] hw/arm/armsse: Fix miswiring of expansion IRQs, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 06/14] hw/char/pl011: Support all interrupt lines, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14