[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 8/8] hw/arm/armsse: Unify init-svtor
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 8/8] hw/arm/armsse: Unify init-svtor and cpuwait handling |
Date: |
Wed, 20 Feb 2019 10:32:18 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/19/19 4:58 AM, Peter Maydell wrote:
> At the moment the handling of init-svtor and cpuwait initial
> values is split between armsse.c and iotkit-sysctl.c:
> the code in armsse.c sets the initial state of the CPU
> object by setting the init-svtor and start-powered-off
> properties, but the iotkit-sysctl.c code has its own
> code setting the reset values of its registers (which are
> then used when updating the CPU when the guest makes
> runtime changes).
>
> Clean this up by making the armsse.c code set properties on the
> iotkit-sysctl object to define the initial values of the
> registers, so they always match the initial CPU state,
> and update the comments in armsse.c accordingly.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/hw/misc/iotkit-sysctl.h | 3 ++
> hw/arm/armsse.c | 49 +++++++++++++++++++++------------
> hw/misc/iotkit-sysctl.c | 20 ++++++--------
> 3 files changed, 42 insertions(+), 30 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-arm] [PATCH 3/8] target/arm/cpu: Allow init-svtor property to be set after realize, (continued)
- [Qemu-arm] [PATCH 3/8] target/arm/cpu: Allow init-svtor property to be set after realize, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 4/8] target/arm/arm-powerctl: Add new arm_set_cpu_on_and_reset(), Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 2/8] hw/arm/armsse: Wire up the MHUs, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 5/8] hw/misc/iotkit-sysctl: Correct typo in INITSVTOR0 register name, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 8/8] hw/arm/armsse: Unify init-svtor and cpuwait handling, Peter Maydell, 2019/02/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH 8/8] hw/arm/armsse: Unify init-svtor and cpuwait handling,
Richard Henderson <=
- [Qemu-arm] [PATCH 6/8] hw/arm/iotkit-sysctl: Add SSE-200 registers, Peter Maydell, 2019/02/19
- [Qemu-arm] [PATCH 7/8] hw/arm/iotkit-sysctl: Implement CPUWAIT and INITSVTOR*, Peter Maydell, 2019/02/19