Re: [PATCH v2 16/22] crypto/cipher-gnutls.c: Clean up local variable shadowing

[Philippe Mathieu-Daudé]

On 4/9/23 18:27, Daniel P. Berrangé wrote:
> On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote:
> > Fix:
> >
> >    In file included from crypto/cipher.c:140:
> >    crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’:
> >    crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a 
> > previous local [-Wshadow=compatible-local]
> >      116 |             int err = gnutls_cipher_init(&handle, ctx->galg, &gkey, 
> > NULL);
> >          |                 ^~~
> >    crypto/cipher-gnutls.c.inc:94:9: note: shadowed declaration is here
> >       94 |     int err;
> >          |         ^~~
> >         ---
> >
> >    crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_decrypt’:
> >    crypto/cipher-gnutls.c.inc:177:17: warning: declaration of ‘err’ shadows a 
> > previous local [-Wshadow=compatible-local]
> >      177 |             int err = gnutls_cipher_init(&handle, ctx->galg, &gkey, 
> > NULL);
> >          |                 ^~~
> >    crypto/cipher-gnutls.c.inc:154:9: note: shadowed declaration is here
> >      154 |     int err;
> >          |         ^~~
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   crypto/cipher-gnutls.c.inc | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> and if you want to include it in general pull request

Sure,

> Acked-by: Daniel P. Berrangé <berrange@redhat.com>

Thank you!