|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [RFC PATCH v2 11/11] hw/char/pl011: Implement TX FIFO |
| Date: | Fri, 13 Oct 2023 16:05:18 +0200 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
On 14/7/23 09:27, Richard Henderson wrote:
On 7/10/23 18:51, Philippe Mathieu-Daudé wrote:+static gboolean pl011_xmit(void *do_not_use, GIOCondition cond, void *opaque)+{ + PL011State *s = opaque; + int ret; + const uint8_t *buf; + uint32_t buflen; + uint32_t count; + bool tx_enabled; + + if (!qemu_chr_fe_backend_connected(&s->chr)) { + /* Instant drain the fifo when there's no back-end */ + return pl011_drain_tx(s); + } + + tx_enabled = s->cr & CR_UARTEN;What happened to "Hello, World"? We ought to be consistent.
What do you mean?
For actual modeling, I think you need TXE too.
| [Prev in Thread] | Current Thread | [Next in Thread] |