Re: [PATCH 2/7] hw/block/vhost-user-blk: Use DEVICE() / VIRTIO_DEVICE() macros

[Manos Pitsidianakis]

On Tue, 17 Oct 2023 17:01, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> Access QOM parent with the proper QOM [VIRTIO_]DEVICE() macros.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/block/vhost-user-blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
> index eecf3f7a81..4b37e26120 100644
> --- a/hw/block/vhost-user-blk.c
> +++ b/hw/block/vhost-user-blk.c
> @@ -405,7 +405,7 @@ static void vhost_user_blk_event(void *opaque, QEMUChrEvent 
> event)
>
> static int vhost_user_blk_realize_connect(VHostUserBlk *s, Error **errp)
> {
> -    DeviceState *dev = &s->parent_obj.parent_obj;
> +    DeviceState *dev = DEVICE(s);
>     int ret;
>
>     s->connected = false;
> @@ -423,7 +423,7 @@ static int vhost_user_blk_realize_connect(VHostUserBlk *s, 
> Error **errp)
>     assert(s->connected);
>
>     ret = vhost_dev_get_config(&s->dev, (uint8_t *)&s->blkcfg,
> -                               s->parent_obj.config_len, errp);
> +                               VIRTIO_DEVICE(s)->config_len, errp);
>     if (ret < 0) {
>         qemu_chr_fe_disconnect(&s->chardev);
>         vhost_dev_cleanup(&s->dev);
> --
> 2.41.0

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>