Re: [PATCH-for-8.2?] hw/arm/fsl-imx: Do not ignore Error argument

[Philippe Mathieu-Daudé]

Hi Markus,

On 21/11/23 07:40, Markus Armbruster wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Mon, 20 Nov 2023 at 11:51, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > > Both i.MX25 and i.MX6 SoC models ignore the Error argument when
> > > setting the PHY number. Pick &error_abort which is the error
> > > used by the i.MX7 SoC (see commit 1f7197deb0 "ability to change
> > > the FEC PHY on i.MX7 processor").
> > >
> > > Fixes: 74c1330582 ("ability to change the FEC PHY on i.MX25 processor")
> > > Fixes: a9c167a3c4 ("ability to change the FEC PHY on i.MX6 processor")
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> >
> >
> >
> > Applied to target-arm.next, thanks.
>
> With or without my commit message clarification?

I didn't get your email on this patch, but per the other
ones on similar fixes:
https://lore.kernel.org/all/87cyw3mu4r.fsf@pond.sub.org/
https://lore.kernel.org/all/87il5vlemo.fsf@pond.sub.org/
I assume you want:

  Both i.MX25 and i.MX6 SoC models ignore the Error argument when
  setting the PHY number with object_property_set_uint(). If this
  @errp argument is set, its following use via sysbus_realize()
  might potentially triggers an assertion in error_setv().

  Pick &error_abort which is the error used by the i.MX7 SoC (see
  commit 1f7197deb0 "ability to change the FEC PHY on i.MX7 processor").

If that is OK with you, Peter, do you mind updating the description?

Thanks both!

Phil.