|
From: | Max Reitz |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] iotests: Remove 006 |
Date: | Tue, 03 Mar 2015 17:10:28 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 2015-03-03 at 17:05, Eric Blake wrote:
On 03/03/2015 02:22 PM, Max Reitz wrote:vpc does support images > 127 GB if done correctly. qemu does it correctly. Remove the test pretending otherwise. Signed-off-by: Max Reitz <address@hidden> --- tests/qemu-iotests/006 | 54 ---------------------------------------------- tests/qemu-iotests/006.out | 6 ------ tests/qemu-iotests/group | 2 +- 3 files changed, 1 insertion(+), 61 deletions(-) delete mode 100755 tests/qemu-iotests/006 delete mode 100644 tests/qemu-iotests/006.outShould the test be rewritten instead to test that we can create and open such a file? But I'm also okay with your decision to nuke it entirely.
Well, in order to test it correctly, we'd have to check whether the CHS configuration is set to 65535/16/255 (as the specification dictates); because that was the purpose of the test, that we cannot exceed that limit (whereas in fact we can).
Dropping is easier, so that's what I did.
Reviewed-by: Eric Blake <address@hidden>
Thanks! Max
[Prev in Thread] | Current Thread | [Next in Thread] |