Re: [Qemu-block] [PATCH] block/dmg: make it modular if using additional library

[Michael Tokarev]

10.03.2015 16:24, Markus Armbruster wrote:
[]
> For me, avoiding bothersome dependencies is a strong practical argument
> for making a something a loadable module.  Other benefits of loadable
> modules presented so far seem pretty negligible to me.  If you want
> them, no objection from me, as long as the cost is similarly negligible,
> additional complexity for developers, packagers and users in particular.

That's the same for me.  No need to reduce code size, at least not
by that much, and no need to disable some "insecure" eg block driver,
but once something pulls in some interesting external dep it seems
to be worth the effort (if it is not large anyway) to make it loadable.

It is much bigger PITA if some feature is needed in some obscure or
rare sutuation but it is not present -- cost of solving this might
be significantly larger than billions of copies of unused code on
billions of user's hdds :)

This is the reason I made it a module or built-in depending on usage
of external dep.

However, in this case libbz2 is most likely present on a user's system
anyway (since at least some time ago it was rather popular, not as
wide as gzip but still significantly; now it is mostly replaced by xz),
so there isn't much of an external dependency.

Thanks,

/mjt