[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of m
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS |
|
Date: |
Fri, 20 Mar 2015 09:04:12 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 03/03/2015 01:13 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> block.c | 2 ++
>> blockdev.c | 18 ++++++++++++++++++
>> include/block/block_int.h | 4 ++++
>> stubs/Makefile.objs | 1 +
>> stubs/blockdev-close-all-bdrv-states.c | 5 +++++
>> 5 files changed, 30 insertions(+)
>> create mode 100644 stubs/blockdev-close-all-bdrv-states.c
>
> Again, might be nice for the commit message to document why adding this
> is useful, but doesn't affect the code.
>
> Reviewed-by: Eric Blake <address@hidden>
Might be nice? This absolutely needs an explanation, in the code!
Why do we need a separate list of "monitor-owned BDS"?
What makes a BDS "monitor-owned"?
What are the invariants governing relations among bdrv_states,
graph_bdrv_states (what a horrible name) and blk_backends?
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server, (continued)
- [Qemu-block] [PATCH v5 05/13] block: Move BDS close notifiers into BB, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 08/13] block: Make bdrv_close() static, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 04/13] quorum: Fix close path, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 13/13] iotests: Add test for multiple BB on BDS tree, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 10/13] blockdev: Keep track of monitor-owned BDS, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 11/13] block: Add blk_remove_all_bs(), Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 09/13] block: Add list of all BlockDriverStates, Max Reitz, 2015/03/03
- [Qemu-block] [PATCH v5 12/13] block: Rewrite bdrv_close_all(), Max Reitz, 2015/03/03
- Re: [Qemu-block] [PATCH v5 00/13] block: Rework bdrv_close_all(), Kevin Wolf, 2015/03/04