[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH COLO v2 06/13] NBD client: implement block d
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication |
Date: |
Wed, 25 Mar 2015 13:50:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 25/03/2015 10:36, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> block/nbd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 3faf865..753b322 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -458,6 +458,52 @@ static void nbd_refresh_filename(BlockDriverState *bs)
> bs->full_open_options = opts;
> }
>
> +static void nbd_start_replication(BlockDriverState *bs, COLOMode mode,
> + Error **errp)
> +{
> + BDRVNBDState *s = bs->opaque;
> +
> + /*
> + * TODO: support COLO_SECONDARY_MODE if we allow secondary
> + * QEMU becoming primary QEMU.
> + */
> + if (mode != COLO_MODE_PRIMARY) {
> + error_set(errp, QERR_INVALID_PARAMETER, "mode");
> + return;
> + }
> +
> + if (s->connected) {
> + error_setg(errp, "The connection is established");
> + return;
> + }
> +
> + /* TODO: NBD client should be one child of quorum, how to verify it? */
> + nbd_connect_server(bs, errp);
> +}
> +
> +static void nbd_do_checkpoint(BlockDriverState *bs, Error **errp)
> +{
> + BDRVNBDState *s = bs->opaque;
> +
> + if (!s->connected) {
> + error_setg(errp, "The connection is not established");
> + return;
> + }
> +}
> +
> +static void nbd_stop_replication(BlockDriverState *bs, Error **errp)
> +{
> + BDRVNBDState *s = bs->opaque;
> +
> + if (!s->connected) {
> + error_setg(errp, "The connection is not established");
> + return;
> + }
> +
> + nbd_client_close(bs);
> + s->connected = false;
> +}
> +
> static BlockDriver bdrv_nbd = {
> .format_name = "nbd",
> .protocol_name = "nbd",
> @@ -527,6 +573,9 @@ static BlockDriver bdrv_nbd_colo = {
> .bdrv_detach_aio_context = nbd_detach_aio_context,
> .bdrv_attach_aio_context = nbd_attach_aio_context,
> .bdrv_refresh_filename = nbd_refresh_filename,
> + .bdrv_start_replication = nbd_start_replication,
> + .bdrv_do_checkpoint = nbd_do_checkpoint,
> + .bdrv_stop_replication = nbd_stop_replication,
>
> .has_variable_length = true,
> };
>
Reviewed-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description, (continued)
Re: [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description, Fam Zheng, 2015/03/26
[Qemu-block] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later, Wen Congyang, 2015/03/25
[Qemu-block] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication, Wen Congyang, 2015/03/25