Re: [Qemu-block] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS

[Wen Congyang]

On 03/26/2015 03:18 PM, Fam Zheng wrote:
> On Thu, 03/26 15:14, Wen Congyang wrote:
>> On 03/26/2015 03:07 PM, Fam Zheng wrote:
>>> On Wed, 03/25 17:36, Wen Congyang wrote:
>>>> When opening BDS, we need to create backup jobs for
>>>> image-fleecing.
>>>
>>> How does this commit message relate to the Makefile change?
>>
>> Hmm, we need to use backup API in block.c, and block.o will
>> be used by qemu-img which doesn't use common-obj.
> 
> I see. How about adding the referenced functions to stubs/?

Good idea. I will try it.

Thanks
Wen Congyang

> 
> Fam
> 
>>
>> Thanks
>> Wen Congyang
>>
>>>
>>>>
>>>> Signed-off-by: Wen Congyang <address@hidden>
>>>> Signed-off-by: zhanghailiang <address@hidden>
>>>> Signed-off-by: Gonglei <address@hidden>
>>>> Cc: Jeff Cody <address@hidden>
>>>> ---
>>>>  block/Makefile.objs | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/block/Makefile.objs b/block/Makefile.objs
>>>> index db2933e..0950973 100644
>>>> --- a/block/Makefile.objs
>>>> +++ b/block/Makefile.objs
>>>> @@ -21,10 +21,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o
>>>>  block-obj-$(CONFIG_LIBSSH2) += ssh.o
>>>>  block-obj-y += accounting.o
>>>>  block-obj-y += write-threshold.o
>>>> +block-obj-y += backup.o
>>>>  
>>>>  common-obj-y += stream.o
>>>>  common-obj-y += commit.o
>>>> -common-obj-y += backup.o
>>>>  
>>>>  iscsi.o-cflags     := $(LIBISCSI_CFLAGS)
>>>>  iscsi.o-libs       := $(LIBISCSI_LIBS)
>>>> -- 
>>>> 2.1.0
>>>>
>>> .
>>>
>>
> .
>