[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC PATCH 6/7] virtio-blk: Don't handle output when th
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker |
Date: |
Wed, 06 May 2015 14:07:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 06/05/2015 13:23, Fam Zheng wrote:
> virtio-blk now listens to op blocker change of the associated block
> backend.
>
> Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO:
>
> non-dataplane:
> 1) Set VirtIOBlock.paused
> 2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused
>
> dataplane:
> 1) Clear the host event notifier
> 2) In handle_notify, do nothing if VirtIOBlock.paused
>
> Up on removing the op blocker:
>
> non-dataplane:
> 1) Clear VirtIOBlock.paused
> 2) Schedule a BH on the AioContext of the backend, which calls
> virtio_blk_handle_output, so that the previous unhandled kicks can
> make progress
>
> dataplane:
> 1) Set the host event notifier
> 2) Notify the host event notifier so that unhandled events are
> processed
>
> Signed-off-by: Fam Zheng <address@hidden>
Does non-dataplane need to do anything, since it uses iohandlers rather
than aio_set_event_notifier_handler?
Paolo
- [Qemu-block] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 1/7] block: Add op blocker type "device IO", Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 2/7] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 3/7] block: Add op blocker notifier list, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 4/7] block-backend: Add blk_op_blocker_add_notifier, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 5/7] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction, Fam Zheng, 2015/05/06
- [Qemu-block] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker, Fam Zheng, 2015/05/06
- Re: [Qemu-block] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker,
Paolo Bonzini <=
- Re: [Qemu-block] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane, Stefan Hajnoczi, 2015/05/07