[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] block: align bounce buffers to page
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 2/2] block: align bounce buffers to page |
|
Date: |
Tue, 12 May 2015 12:50:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 12/05/2015 12:27, Kevin Wolf wrote:
> I think it would make more sense to keep this specific to the raw-posix
> driver. After all, it's only the kernel page cache that we optimise
> here. Other backends probably don't take advantage of page alignment.
I don't think it makes sense to keep it raw-posix-specific, though.
It's not the page cache that we optimize for, because this is with
O_DIRECT. If anything, making it page aligned means that the buffer
spans one fewer physical page and thus it may economize a bit on TLB misses.
Paolo