[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 12/34] block: Allow specifying driv
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 12/34] block: Allow specifying driver-specific options to reopen |
Date: |
Tue, 12 May 2015 08:59:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 42 +++++++++++++++++++++++++++++++++++++++---
> block/commit.c | 4 ++--
> include/block/block.h | 4 +++-
> 3 files changed, 44 insertions(+), 6 deletions(-)
>
> diff --git a/block.c b/block.c
> index 95dc51e..561cefd 100644
> --- a/block.c
> +++ b/block.c
> @@ -1584,6 +1584,9 @@ typedef struct BlockReopenQueueEntry {
> *
> * bs is the BlockDriverState to add to the reopen queue.
> *
> + * options contains the changed options for the associated bs
> + * (the BlockReopenQueue takes the ownership)
'takes ownership' reads a bit more idiomatically, but what you have is
not wrong.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 11/34] block: Allow references for backing files, (continued)
[Qemu-block] [PATCH 13/34] qemu-io: Add command 'reopen', Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 12/34] block: Allow specifying driver-specific options to reopen, Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 14/34] qcow2: Factor out qcow2_update_options(), Kevin Wolf, 2015/05/08
Re: [Qemu-block] [PATCH 14/34] qcow2: Factor out qcow2_update_options(), Max Reitz, 2015/05/13
Re: [Qemu-block] [PATCH 14/34] qcow2: Factor out qcow2_update_options(), Max Reitz, 2015/05/13
[Qemu-block] [PATCH 15/34] qcow2: Move qcow2_update_options() call up, Kevin Wolf, 2015/05/08
[Qemu-block] [PATCH 16/34] qcow2: Move rest of option handling to qcow2_update_options(), Kevin Wolf, 2015/05/08