Re: [Qemu-block] [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions

[Kevin Wolf]

Am 12.05.2015 um 23:40 hat Eric Blake geschrieben:
> On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> > Before we can allow updating options at runtime with bdrv_reopen(), we
> > need to split the function into prepare/commit/abort parts.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block/qcow2.c | 101 
> > ++++++++++++++++++++++++++++++++++++++--------------------
> >  1 file changed, 67 insertions(+), 34 deletions(-)
> > 
> 
> In isolation, it looks like a valid conversion, so:
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> However, given that we are having a conversation on another thread about
> semantics for prepare vs. commit being the action that actually changes
> the in-memory representation, is this the correct split for however we
> end up resolving that bug?

Reopen transactions are a different thing than QMP transactions, so I
hope that they are not affected by that discussion. Generally, my
assumption with reopen transactions is that the change only takes effect
in commit.

Kevin

pgpOpJna5UBgs.pgp
Description: PGP signature