Re: [Qemu-block] [PATCH 23/34] block: Pass driver-specific options to .bdrv_refresh_filename()

[Max Reitz]

On 08.05.2015 19:21, Kevin Wolf wrote:
> In order to decide whether a blkdebug: filename can be produced or a
> json: one is necessary, blkdebug checked whether bs->options had more
> options than just "config", "x-image" or "image" (the latter including
> nested options). That doesn't work well when generic block layer options
> are present.
>
> This patch passes an option QDict to the driver that contains only
> driver-specific options, i.e. the options for the general block layer as
> well as child nodes are already filtered out. Works much better this
> way.

Indeed. :-)

> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   block.c                   |  5 ++++-
>   block/blkdebug.c          | 17 ++++++-----------
>   block/blkverify.c         |  2 +-
>   block/nbd.c               | 10 +++++-----
>   block/quorum.c            |  2 +-
>   include/block/block_int.h |  2 +-
>   6 files changed, 18 insertions(+), 20 deletions(-)

Reviewed-by: Max Reitz <address@hidden>