[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 11/11] block: Block "device IO" during bdrv_d
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all |
Date: |
Wed, 13 May 2015 17:25:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 13/05/2015 17:17, Fam Zheng wrote:
>> >
>> > It can be the topic of a separate series. But this patch brings a
>> > false sense of security (either the blocker is unnecessary, or it
>> > needs to last after bdrv_drain returns), so I think it should be
>> > dropped.
> Doesn't this let bdrv_drain_all return when virtio-blk-dataplane is having
> high
> workload, in places where you say "the blocker is unnecessary"?
Yes, you're right. Please document it in the commit message and the
code, it's tricky.
Paolo
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, (continued)
Re: [Qemu-block] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction, Paolo Bonzini, 2015/05/13
[Qemu-block] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all, Fam Zheng, 2015/05/13