[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/5] Fix migration in case of sc
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic |
|
Date: |
Thu, 14 May 2015 15:21:11 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 14/05/2015 13:02, Dimitris Aragiorgis wrote:
> Also note that QEMU seems to flush the disk cache explicitly in
> case of iSCSI, using iscsi_synchronizecache10_task() from libiscsi
> inside iscsi_co_flush().
Right, QEMU does that if type is DISK only.
> Perhaps we can also extend this approach to scsi-generic e.g. by
> calling sg_ll_sync_cache_10() from libsgutils2. This is a distinct,
> orthogonal patch that could be added in the future.
Yes. But do not use libsgutils2, just do it manually in QEMU. See
for example get_stream_blocksize in hw/scsi/scsi-generic.c.
Paolo
- [Qemu-block] [PATCH v2 0/5] Some fixes related to scsi-generic, Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT, Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere, Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg(), Dimitris Aragiorgis, 2015/05/08
- [Qemu-block] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY, Dimitris Aragiorgis, 2015/05/08